Make deploys independent of build artifact #90
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deploy for PR #89 failed because the existing workflows for build and deploy were dependent, the
build-ci-testworkflow (which runs on PRs) generated a build artifact, which then was downloaded by thedeploy-gh-pagesworkflow, when it ran (on push). However in the above case, the deploy workflow could not download the artifact, since the build workflow ran on a fork of the repo, not the main repo itself.This PR changes the workflows to not upload/download artifact, and instead perform repeated builds, once in the
build-ci-testworkflow, and once more in thedeploy-gh-pagesworkflow.Type of change
Checklist: